Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete to REPL #16

Closed
ziflex opened this issue Sep 19, 2018 · 5 comments
Closed

Add autocomplete to REPL #16

ziflex opened this issue Sep 19, 2018 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed type/enhancement New feature or request

Comments

@ziflex
Copy link
Member

ziflex commented Sep 19, 2018

It would improve usability of REPL if we added autocomplete for registered functions.

@ziflex ziflex added type/enhancement New feature or request good first issue Good for newcomers area/cli labels Sep 19, 2018
@SumLare
Copy link
Contributor

SumLare commented Oct 7, 2018

I want to help with this one, not sure where to look up for registered functions

@ziflex
Copy link
Member Author

ziflex commented Oct 7, 2018

@SumLare great!
At this moment, there is no such functionality, you need to add one, something like this to the compiler:

func (c *Compiler) RegisteredFunctions() []string {
	res := make([]string, 0, len(c.functions))

	for name := range c.functions {
		res = append(res, name)
	}

	return res
}

@ziflex
Copy link
Member Author

ziflex commented Oct 7, 2018

With DSL syntax itself it's more tricky. You need to take a look at the parser and figure out how to get lexer's tokens.

@ziflex ziflex added the help wanted Extra attention is needed label Dec 13, 2018
@ziflex ziflex pinned this issue Dec 15, 2018
@3timeslazy
Copy link
Member

@ziflex we can extract it from this

@ziflex
Copy link
Member Author

ziflex commented Jan 19, 2019

Closed #219

@ziflex ziflex closed this as completed Jan 19, 2019
@ziflex ziflex unpinned this issue Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants