Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background setting not functional #5

Open
bytesparrow opened this issue Jun 4, 2024 · 0 comments
Open

background setting not functional #5

bytesparrow opened this issue Jun 4, 2024 · 0 comments

Comments

@bytesparrow
Copy link

bytesparrow commented Jun 4, 2024

Hi,
first of all a big thanks for the theme Boost Union.
Providing child-theme is furthermore a really great service!

I've had one issue with it regarding the background image:

  • activate child theme
  • set a background for your site
  • it will not show up
  • neither in inheritance/duplicate mode

I propose the following solution:
in lib.php/theme_boost_union_child_get_extra_scss
change line 112 to

$scss .= theme_config::load('boost_union')->get_extra_scss_code();

set mode to duplicate

Similar in line 74: change it to

$scss .= theme_config::load('boost_union')->get_pre_scss_code()

The site background will work now.

Why?

  • The SCSS for the site-background is done in theme Boost.
  • Using the Moodle-API inheritance will kick in and not only the function _ theme_boost_union_child_get_extra_scss _ will be executed but ALSO _ theme_boost_get_extra_scss _

Maybe it should be pointed out, that the site background does not work in inheritance mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant