Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Important info missing from Javascript #622

Closed
marxjohnson opened this issue May 12, 2023 · 0 comments · Fixed by #758
Closed

[docs] Important info missing from Javascript #622

marxjohnson opened this issue May 12, 2023 · 0 comments · Fixed by #758
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@marxjohnson
Copy link
Contributor

What is the URL of the page?

https://moodledev.io/docs/guides/javascript

What is the issue with this page?

As highlighted in this discussion, the Javascript development guide doesn't mention the very important step of running grunt to build your Javascript. This is mentioned separately on the Modules page, but a new developer following the examples on the Javascript guide won't know to look there too. In fact, there appears to be quite a bit of duplication between these pages, both explaining Moodle's Javascript module format and both giving different examples of how to write "your first module".

Are you able to provide a patch for this?

None

@marxjohnson marxjohnson added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed labels May 12, 2023
@sarjona sarjona linked a pull request Oct 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants