mod/quiz: remove deprecated sql_paging_limit(), use offset, limit par…

…ameters
moodle · Sep 26, 2006 · 1ad5c63 · 1ad5c63
1 parent 1e7368e
commit 1ad5c63
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/mod/quiz/report/grading/report.php b/mod/quiz/report/grading/report.php
@@ -240,14 +240,8 @@ function view_question($quiz, $question) {
         $total  = count_records_sql('SELECT COUNT(DISTINCT('.sql_concat('u.id', '\'#\'', $db->IfNull('qa.attempt', '0')).')) '.$from.$where);
         $table->pagesize(10, $total);
 
-        // this is for getting the correct records for a given page
-        if($table->get_page_start() !== '' && $table->get_page_size() !== '') {
-            $limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size());
-        } else {
-            $limit = '';
-        }
         // get the attempts and process them
-        if ($attempts = get_records_sql($select.$from.$where.$sort.$limit)) {
+        if ($attempts = get_records_sql($select.$from.$where.$sort,$table->get_page_start(), $table->get_page_size())) {
             foreach($attempts as $attempt) {
 
                 $picture = print_user_picture($attempt->userid, $quiz->course, $attempt->picture, false, true);

diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php
@@ -94,7 +94,6 @@ function display($quiz, $cm, $course) {
         if ($download) {
             $filename = clean_filename("$course->shortname ".format_string($quiz->name,true));
             $sort = '';
-            $limit = '';
         }
 
         // Define table columns
@@ -339,12 +338,6 @@ function display($quiz, $cm, $course) {
                 $pagesize = 10;
             }
             $table->pagesize($pagesize, $total);
-
-            if($table->get_page_start() !== '' && $table->get_page_size() !== '') {
-                $limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size());
-            } else {
-                $limit = '';
-            }
         }
 
         // If there is feedback, include it in the query.
@@ -357,7 +350,8 @@ function display($quiz, $cm, $course) {
 
         // Fetch the attempts
         if (!empty($from)) { // if we're in the site course and displaying no attempts, it makes no sense to do the query.
-            $attempts = get_records_sql($select.$from.$where.$sort.$limit);
+            $attempts = get_records_sql($select.$from.$where.$sort,
+                                        $table->get_page_start(), $table->get_page_size());
         } else {
             $attempts = array();
         }