mirrored from git://git.moodle.org/moodle.git
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MDL-39945 qtype multichoice was not comparing blank responses correctly.
- Loading branch information
1 parent
94572e5
commit 22be561
Showing
4 changed files
with
188 additions
and
116 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
152 changes: 152 additions & 0 deletions
152
question/type/multichoice/tests/question_multi_test.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| <?php | ||
| // This file is part of Moodle - http://moodle.org/ | ||
| // | ||
| // Moodle is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // Moodle is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with Moodle. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| /** | ||
| * Unit tests for the multiple choice, multi-response question definition classes. | ||
| * | ||
| * @package qtype_multichoice | ||
| * @copyright 2009 The Open University | ||
| * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
| */ | ||
|
|
||
| defined('MOODLE_INTERNAL') || die(); | ||
|
|
||
| global $CFG; | ||
| require_once($CFG->dirroot . '/question/engine/tests/helpers.php'); | ||
|
|
||
|
|
||
| /** | ||
| * Unit tests for the multiple choice, multi-response question definition class. | ||
| * | ||
| * @copyright 2009 The Open University | ||
| * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
| */ | ||
| class qtype_multichoice_multi_question_test extends advanced_testcase { | ||
|
|
||
| public function test_get_expected_data() { | ||
| $question = test_question_maker::make_a_multichoice_multi_question(); | ||
| $question->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertEquals(array('choice0' => PARAM_BOOL, 'choice1' => PARAM_BOOL, | ||
| 'choice2' => PARAM_BOOL, 'choice3' => PARAM_BOOL), $question->get_expected_data()); | ||
| } | ||
|
|
||
| public function test_is_complete_response() { | ||
| $question = test_question_maker::make_a_multichoice_multi_question(); | ||
| $question->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertFalse($question->is_complete_response(array())); | ||
| $this->assertFalse($question->is_complete_response( | ||
| array('choice0' => '0', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'))); | ||
| $this->assertTrue($question->is_complete_response(array('choice1' => '1'))); | ||
| $this->assertTrue($question->is_complete_response( | ||
| array('choice0' => '1', 'choice1' => '1', 'choice2' => '1', 'choice3' => '1'))); | ||
| } | ||
|
|
||
| public function test_is_gradable_response() { | ||
| $question = test_question_maker::make_a_multichoice_multi_question(); | ||
| $question->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertFalse($question->is_gradable_response(array())); | ||
| $this->assertFalse($question->is_gradable_response( | ||
| array('choice0' => '0', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'))); | ||
| $this->assertTrue($question->is_gradable_response(array('choice1' => '1'))); | ||
| $this->assertTrue($question->is_gradable_response( | ||
| array('choice0' => '1', 'choice1' => '1', 'choice2' => '1', 'choice3' => '1'))); | ||
| } | ||
|
|
||
| public function test_is_same_response() { | ||
| $question = test_question_maker::make_a_multichoice_multi_question(); | ||
| $question->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertTrue($question->is_same_response( | ||
| array(), | ||
| array('choice0' => '0', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'))); | ||
|
|
||
| $this->assertTrue($question->is_same_response( | ||
| array('choice0' => '0', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'), | ||
| array('choice0' => '0', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'))); | ||
|
|
||
| $this->assertFalse($question->is_same_response( | ||
| array('choice0' => '0', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'), | ||
| array('choice0' => '1', 'choice1' => '0', 'choice2' => '0', 'choice3' => '0'))); | ||
|
|
||
| $this->assertTrue($question->is_same_response( | ||
| array('choice0' => '1', 'choice1' => '0', 'choice2' => '1', 'choice3' => '0'), | ||
| array('choice0' => '1', 'choice1' => '0', 'choice2' => '1', 'choice3' => '0'))); | ||
| } | ||
|
|
||
| public function test_grading() { | ||
| $question = test_question_maker::make_a_multichoice_multi_question(); | ||
| $question->shuffleanswers = false; | ||
| $question->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertEquals(array(1, question_state::$gradedright), | ||
| $question->grade_response(array('choice0' => '1', 'choice2' => '1'))); | ||
| $this->assertEquals(array(0.5, question_state::$gradedpartial), | ||
| $question->grade_response(array('choice0' => '1'))); | ||
| $this->assertEquals(array(0, question_state::$gradedwrong), | ||
| $question->grade_response( | ||
| array('choice0' => '1', 'choice1' => '1', 'choice2' => '1'))); | ||
| $this->assertEquals(array(0, question_state::$gradedwrong), | ||
| $question->grade_response(array('choice1' => '1'))); | ||
| } | ||
|
|
||
| public function test_get_correct_response() { | ||
| $question = test_question_maker::make_a_multichoice_multi_question(); | ||
| $question->shuffleanswers = false; | ||
| $question->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertEquals(array('choice0' => '1', 'choice2' => '1'), | ||
| $question->get_correct_response()); | ||
| } | ||
|
|
||
| public function test_get_question_summary() { | ||
| $mc = test_question_maker::make_a_multichoice_single_question(); | ||
| $mc->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $qsummary = $mc->get_question_summary(); | ||
|
|
||
| $this->assertRegExp('/' . preg_quote($mc->questiontext, '/') . '/', $qsummary); | ||
| foreach ($mc->answers as $answer) { | ||
| $this->assertRegExp('/' . preg_quote($answer->answer, '/') . '/', $qsummary); | ||
| } | ||
| } | ||
|
|
||
| public function test_summarise_response() { | ||
| $mc = test_question_maker::make_a_multichoice_multi_question(); | ||
| $mc->shuffleanswers = false; | ||
| $mc->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $summary = $mc->summarise_response(array('choice1' => 1, 'choice2' => 1), | ||
| test_question_maker::get_a_qa($mc)); | ||
|
|
||
| $this->assertEquals('B; C', $summary); | ||
| } | ||
|
|
||
| public function test_classify_response() { | ||
| $mc = test_question_maker::make_a_multichoice_multi_question(); | ||
| $mc->shuffleanswers = false; | ||
| $mc->start_attempt(new question_attempt_step(), 1); | ||
|
|
||
| $this->assertEquals(array( | ||
| 13 => new question_classified_response(13, 'A', 0.5), | ||
| 14 => new question_classified_response(14, 'B', -1.0), | ||
| ), $mc->classify_response(array('choice0' => 1, 'choice1' => 1))); | ||
|
|
||
| $this->assertEquals(array(), $mc->classify_response(array())); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters