MDL-35698 quiz cron: group overrides not computed correctly

Thanks to Matt Petro for finding the bug in this monster SQL statement.
moodle · Sep 29, 2012 · 2d04a1f · 2d04a1f
1 parent 9273bd1
commit 2d04a1f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/mod/quiz/cronlib.php b/mod/quiz/cronlib.php
@@ -117,8 +117,8 @@ protected function get_list_of_overdue_attempts($processfrom, $processto) {
            FROM {quiz_attempts} iquiza
            JOIN {quiz} quiz ON quiz.id = iquiza.quiz
       LEFT JOIN {quiz_overrides} quo ON quo.quiz = quiz.id AND quo.userid = iquiza.userid
-      LEFT JOIN {quiz_overrides} qgo ON qgo.quiz = quiz.id
+      LEFT JOIN {groups_members} gm ON gm.userid = iquiza.userid
-      LEFT JOIN {groups_members} gm ON gm.userid = iquiza.userid AND gm.groupid = qgo.groupid
+      LEFT JOIN {quiz_overrides} qgo ON qgo.quiz = quiz.id AND qgo.groupid = gm.groupid
 
           WHERE iquiza.state IN ('inprogress', 'overdue')
             AND iquiza.timemodified >= :processfrom