MDL-13572 message: added validation of the email address in the messa…

…ging preferences
moodle · Jan 2, 2012 · 63601aa · 63601aa
1 parent 464ad0a
commit 63601aa
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/message/output/email/message_output_email.php b/message/output/email/message_output_email.php
@@ -68,12 +68,19 @@ function send_message($eventdata) {
      * @param object $mform preferences form class
      */
     function config_form($preferences){
-        global $USER;
+        global $USER, $OUTPUT;
-        $string = get_string('email','message_email').': <input size="30" name="email_email" value="'.$preferences->email_email.'" />';
+
+        $inputattributes = array('size'=>'30', 'name'=>'email_email', 'value'=>$preferences->email_email);
+        $string = get_string('email','message_email') . ': ' . html_writer::empty_tag('input', $inputattributes);
 
         if (empty($preferences->email_email) && !empty($preferences->userdefaultemail)) {
             $string .= ' ('.get_string('default').': '.$preferences->userdefaultemail.')';
         }
+
+        if (!empty($preferences->email_email) && !validate_email($preferences->email_email)) {
+            $string .= $OUTPUT->container(get_string('invalidemail'), 'error');
+        }
+
         return $string;
     }