MDL-37374 questions: use property_exists rather than isset

$a->field = null; isset($a->field) returns false, which is typical PHP. I also improve the error handling a bit.
moodle · Jan 11, 2013 · 7d9ce88 · 7d9ce88
1 parent dbee98b
commit 7d9ce88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/question/type/edit_question_form.php b/question/type/edit_question_form.php
@@ -481,7 +481,7 @@ public function set_data($question) {
         if (is_array($extraquestionfields) && !empty($question->options)) {
             array_shift($extraquestionfields);
             foreach ($extraquestionfields as $field) {
-                if (isset($question->options->$field)) {
+                if (property_exists($question->options->$field)) {
                     $question->$field = $question->options->$field;
                 }
             }

diff --git a/question/type/questiontypebase.php b/question/type/questiontypebase.php
@@ -454,21 +454,12 @@ public function save_question_options($question) {
                 $options->$questionidcolname = $question->id;
             }
             foreach ($extraquestionfields as $field) {
-                if (!isset($question->$field)) {
+                if (property_exists($question->$field)) {
-                    $result = new stdClass();
+                    $options->$field = $question->$field;
-                    $result->error = "No data for field $field when saving " .
-                            $this->name() . ' question id ' . $question->id;
-                    return $result;
                 }
-                $options->$field = $question->$field;
             }
 
-            if (!$DB->{$function}($question_extension_table, $options)) {
+            $DB->{$function}($question_extension_table, $options);
-                $result = new stdClass();
-                $result->error = 'Could not save question options for ' .
-                        $this->name() . ' question id ' . $question->id;
-                return $result;
-            }
         }
 
         $extraanswerfields = $this->extra_answer_fields();