MDL-57604 mod_assign: fix empty case in user selector

Sadly the js arguments object gives an arguments.length of 1 when no arguments are passed, so we have to explicitly check for it.
moodle · Jan 18, 2017 · c52766a · c52766a
1 parent c2a9f46
commit c52766a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/mod/assign/amd/build/participant_selector.min.js b/mod/assign/amd/build/participant_selector.min.js
diff --git a/mod/assign/amd/src/participant_selector.js b/mod/assign/amd/src/participant_selector.js
@@ -95,8 +95,14 @@ define(['core/ajax', 'jquery', 'core/templates'], function(ajax, $, templates) {
                 // Do the dance for $.when()
                 return $.when.apply($, promises);
             }).then(function() {
-                // Undo the $.when() dance from arguments object into an array..
-                var users = Array.prototype.slice.call(arguments);
+                var users = [];
+
+                // Determine if we've been passed any arguments..
+                if (arguments[0]) {
+                    // Undo the $.when() dance from arguments object into an array..
+                    users = Array.prototype.slice.call(arguments);
+                }
+
                 success(users);
             }).catch(failure);
         }