MDL-32155 blocks: User can't access file, if block is hidden or doesn…

…'t have block:view capability
moodle · May 23, 2012 · c58c05a · c58c05a
1 parent 14fdcb4
commit c58c05a
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/lib/filelib.php b/lib/filelib.php
@@ -3898,6 +3898,12 @@ function file_pluginfile($relativepath, $forcedownload) {
                 // somebody tries to gain illegal access, cm type must match the component!
                 send_file_not_found();
             }
+
+            $bprecord = $DB->get_record('block_positions', array('blockinstanceid' => $context->instanceid), 'visible');
+            // User can't access file, if block is hidden or doesn't have block:view capability
+            if (($bprecord && !$bprecord->visible) || !has_capability('moodle/block:view', $context)) {
+                 send_file_not_found();
+            }
         } else {
             $birecord = null;
         }