MDL-30655 Blocks: Moving block to top of list can cause (harmless) PH…

…P warnings
moodle · Dec 9, 2011 · cff596e · cff596e
1 parent acb3bf8
commit cff596e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/blocklib.php b/lib/blocklib.php
@@ -1467,8 +1467,10 @@ public function process_url_move() {
         } else {
             $newweight = ceil($newweight);
             for ($weight = $bestgap - 1; $weight >= $newweight; $weight--) {
-                foreach ($usedweights[$weight] as $biid) {
+                if (array_key_exists($weight, $usedweights)) {
-                    $this->reposition_block($biid, $newregion, $weight + 1);
+                    foreach ($usedweights[$weight] as $biid) {
+                        $this->reposition_block($biid, $newregion, $weight + 1);
+                    }
                 }
             }
             $this->reposition_block($block->instance->id, $newregion, $newweight);