mod/glossary, mod/hotpot: use sql_concat() and sql_concat_join()

Cleaned up several dbtype conditionals too.
moodle · Sep 26, 2006 · d2715c7 · d2715c7
1 parent 38e02f4
commit d2715c7
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 26 deletions.
diff --git a/mod/glossary/sql.php b/mod/glossary/sql.php
@@ -92,9 +92,9 @@
         break;
         case 'mysql':
             if ( $sqlsortkey == 'FIRSTNAME' ) {
-                $usernamefield = "CONCAT(CONCAT(u.firstname,' '), u.lastname)";
+                $usernamefield = sql_fullname('u.firstname' , 'u.lastname');
             } else {
-                $usernamefield = "CONCAT(CONCAT(u.lastname,' '), u.firstname)";
+                $usernamefield = sql_fullname('u.lastname' , 'u.firsttname');
             }
             $where = "AND left(ucase($usernamefield)," .  $textlib->strlen($hook, current_charset()) . ") = '$hook'";
         break;

diff --git a/mod/hotpot/index.php b/mod/hotpot/index.php
@@ -203,14 +203,8 @@
         $questions = false;
         $regradehotpots = array();
 
-        switch (strtolower($CFG->dbtype)) {
+        $field = sql_concat('hotpot', "'_'", 'name');
-            case 'mysql' : 
+
-                $field = "CONCAT(hotpot, '_', name)";
-                break;
-            case 'postgres7' :
-                $field = "hotpot||'_'||name";
-                break;
-        }
         if ($field) {
             $questions = get_records_sql("
                 SELECT $field, COUNT(*), hotpot, name

diff --git a/mod/hotpot/lib.php b/mod/hotpot/lib.php
@@ -1089,17 +1089,31 @@ function hotpot_get_grades($hotpot, $user_ids='') {
             break;
         case HOTPOT_GRADEMETHOD_FIRST:
             if ($CFG->dbtype=='postgres7') {
-                $grade = "MIN(timestart||'_'||(CASE WHEN (score IS NULL) THEN '' ELSE TRIM(ROUND(score * $weighting, $precision)) END)) AS grade";
+                $grade = "(CASE WHEN (score IS NULL) 
+                                THEN '' 
+                                ELSE TRIM(ROUND(score * $weighting, $precision)) 
+                           END)";
             } else {
-                $grade = "MIN(CONCAT(timestart, '_', IF(score IS NULL, '', ROUND(score * $weighting, $precision)))) AS grade";
+                $grade = "IF(score IS NULL, 
+                             '', 
+                             ROUND(score * $weighting, $precision))";
             }
+            $grade = sql_concat('timestart', "'_'", $grade);
+            $grade = "MIN($grade) AS grade";
             break;
         case HOTPOT_GRADEMETHOD_LAST:
             if ($CFG->dbtype=='postgres7') {
-                $grade = "MAX(timestart||'_'||(CASE WHEN (score IS NULL) THEN '' ELSE TRIM(ROUND(score * $weighting, $precision)) END)) AS grade";
+                $grade = "(CASE WHEN (score IS NULL) 
+                                THEN '' 
+                                ELSE TRIM(ROUND(score * $weighting, $precision)) 
+                           END)";
             } else {
-                $grade = "MAX(CONCAT(timestart, '_', IF(score IS NULL, '', ROUND(score * $weighting, $precision)))) AS grade";
+                $grade = "IF(score IS NULL, 
+                             '', 
+                             ROUND(score * $weighting, $precision))";
             }
+            $grade = sql_concat('timestart', "'_'", $grade);
+            $grade = "MAX($grade) AS grade";
             break;
     }
 

diff --git a/mod/hotpot/report.php b/mod/hotpot/report.php
@@ -594,18 +594,8 @@ function hotpot_get_records_groupby($function, $fieldnames, $table, $select, $gr
     // $function is an SQL aggregate function (MAX or MIN)
 
     global $CFG;
-
+    $fields = sql_concat_join("'_'", $fieldnames);
-    switch (strtolower($CFG->dbtype)) {
+    $fields = "$groupby, $function($fields) AS joinedvalues";
-        case 'mysql':
-            $fields = "$groupby, $function(CONCAT(".join(",'_',", $fieldnames).")) AS joinedvalues";
-            break;
-        case 'postgres7':
-            $fields = "$groupby, $function(".join("||'_'||", $fieldnames).") AS joinedvalues";
-            break;
-        default:
-            $fields = "";
-            break;
-    }
 
     if ($fields) {
         $records = get_records_sql("SELECT $fields FROM $table WHERE $select GROUP BY $groupby");