MDL-15184: fix sql injection vulnerability

moodle · Jul 1, 2008 · e5e02e4 · e5e02e4
1 parent 36ea9a6
commit e5e02e4
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/mod/hotpot/report.php b/mod/hotpot/report.php
@@ -380,10 +380,14 @@ function hotpot_delete_selected_attempts(&$hotpot, $del) {
             $select = "hotpot=:hotpotid AND status=".HOTPOT_STATUS_ABANDONED;
             break;
         case 'selection':
-            $ids = (array)data_submitted();
+            $ids = array();
-            unset($ids['del']);
+            $data = (array)data_submitted();
-            unset($ids['id']);
+            foreach ($data as $name => $value) {
-            if (!empty($ids)) {
+                if (preg_match('/^box\d+$/', $name)) {
+                    $ids[] = intval($value);
+                }
+            }
+            if (count($ids)) {
                 list($ids, $idparams) = $DB->get_in_or_equal($ids, SQL_PARAMS_NAMED, 'crid0');
                 $params = array_merge($params, $idparams); 
                 $select = "hotpot=:hotpotid AND clickreportid $ids";