moodle-plugin-ci on GitLab CI (extended) #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and removing phpenv command since it does not work
|
Should have commented sooner, but supporting other CI systems is out of scope for this project. Thank you for the time you spent on this. I'd be happy to create a doc page with a link to something like a GitHub Gist with the YAML for GitLab. Then folks can collaborate there on it. |
|
Sure, I do not require official support, as it is running perfectly fine right now :) I liked your idea of creating a gist for the YAML file, so I pasted this pull request's file here: https://gist.github.com/Dagefoerde/b8ebf54438b8a77ee4ea73f552fc0a01 . I guess, others would appreciate a link to this gist. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have applied the awesome idea of @danielneis (#15) to my own projects and found it very useful. I have modified the config in the following ways:
job_template) from which builds can inherit. Builds can then specify their respective PHP versions and Moodle branches.nodeto thenodejsbinary, sincecsslintexpects to be able to callnode.phpenvto remove xdebug, as it did not work out for me.Sorry for creating an additional pull request; I was unable to modify @danielneis's branch myself. Branched from his commit, though :)