Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo-remover status? #168

Closed
janosh opened this issue Oct 6, 2020 · 6 comments
Closed

repo-remover status? #168

janosh opened this issue Oct 6, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@janosh
Copy link

janosh commented Oct 6, 2020

I'm getting an infinite spinner on the latest Chrome (85) and macOS (10.15.7). Disabled all Chrome extensions just in case. Problem remains.

spinner

@cleor41
Copy link

cleor41 commented Oct 7, 2020

Same

@moollaza
Copy link
Owner

moollaza commented Oct 7, 2020

I just tested and it seems to be working currently.

Edit: I see this now in Chrome and Safari, however Firefox seems to be working fine.

I haven't pushed and changes in a while so I suspect it might be an upstream issues. I'll have to investigate further.

@moollaza moollaza self-assigned this Oct 7, 2020
@janosh
Copy link
Author

janosh commented Oct 7, 2020

Just retested. Still not working for me. Nothing logged to console.

@moollaza moollaza added the bug Something isn't working label Oct 7, 2020
@moollaza
Copy link
Owner

moollaza commented Oct 7, 2020

Thanks for confirming @janosh

I've confirmed the breakage occurred in this PR: #156

It should be working in the previous build here though: https://repo-remover-git-dependabot-npmandyarndot-prop-421.moollaza.vercel.app/

I'll have to debug what changed in the VueJS update that caused this breakage.

@moollaza
Copy link
Owner

moollaza commented Oct 7, 2020

This should be fixed. I've reverted the PR that caused the issue.

I dug into this for a while, but can't determine what's actually causing the issue.

It appears that for some reason the result() callback is not called in Chrome/Safari when the GraphQl API response is returned, so the loading state is never disabled.

@moollaza moollaza closed this as completed Oct 7, 2020
@janosh
Copy link
Author

janosh commented Oct 7, 2020

Confirmed working again. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants