Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of ContainerChain AUthorship in runtime should happen during block execution #54

Open
girazoki opened this issue Apr 5, 2023 · 0 comments

Comments

@girazoki
Copy link
Collaborator

girazoki commented Apr 5, 2023

Right now the runtime verification of the block seal is done with the authorities before the block was created: https://github.com/paritytech/cumulus/blob/b49628f316c1086fd2f5cc8ef2a52cceca8b8818/pallets/aura-ext/src/lib.rs#L118. While this is fine for Tanssi (otherwise runtime-APIs would suffer), we should modify this in the containerChains such that the verification happens during the block execution, and not before.
https://github.com/paritytech/substrate/blob/5380a9a513918c144175cf2a48d66a35e6e7cad4/client/consensus/aura/src/lib.rs#L511

@girazoki girazoki changed the title Verification of Aura should happen with the queuedAuthorities on session changes, and not with the previous authorities Verification of ContainerChain AUthorship in runtime should happen during block execution Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant