Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: remove Lua path-related duplicate code in **/test.sh and **/init.lua #5

Open
bofm opened this issue Jul 3, 2018 · 1 comment

Comments

@bofm
Copy link

bofm commented Jul 3, 2018

There is the same code piece in Bash repeated in test.sh in basic/ and vshard/ templates. Also there seems to be the same code in Lua in **/init.lua. Those pieces of code are related to Lua path and cpath definition. It would be great if that code was moved to a single place to avoid copy-paste.

@igorcoding
Copy link
Member

I agree on that, currently I'm thinking of a better way to add paths to make it relatively simple and obvious to understand where everything comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants