Snap builds broken on master

[maxiberta]

Hi! Snap builds are currently broken on master:

gui/sdlgamepadkeynavigation.cpp: In member function ‘void SdlGamepadKeyNavigation::sendWheel(QPoint&)’:
gui/sdlgamepadkeynavigation.cpp:253:145: error: no matching function for call to ‘QWheelEvent::QWheelEvent(QPoint&, QPoint&, QPoint, QPoint&, int, int, Qt::ScrollPhase, bool, Qt::MouseEventSource)’
         QWheelEvent wheelEvent(mousePos, globalPos, QPoint(), angleDelta, 0, 0, Qt::NoScrollPhase, false, Qt::MouseEventSynthesizedByApplication);

I think this is the relevant commit. I'm no expert but it looks like a newer Qt is expected?

The snap is currently based on core18 + Qt 5.9. It could hopefully be based on core20 + Qt 5.12 soon, but the qmake plugin does not yet support core20. Alternatively, the snap could use a custom build of Qt - feasible, but not trivial.

Cheers! o/

[auto-comment]

If this is a question about Moonlight or you need help troubleshooting a streaming problem, please use the help channels on our Discord server instead of GitHub issues. There are many more people available on Discord to help you and answer your questions.

This issue tracker should only be used for specific bugs or feature requests.

Thank you, and happy streaming!

[cgutman]

Thanks, I pushed a fix. I saw that the Steam Link's Qt 5.9 build was failing too.

On the subject of a newer Qt, I am hoping to be able to drop Qt 5.9 support soon. It will also be nice to have the dependencies and other libraries updated too.

Maybe we could make it work with core20 on Snapcraft 4.0 by using the make plugin and using override-build to run qmake first?

[maxiberta]

Thanks!
Quick update: already published a core20 based snap to the edge channel (the make hack was a great idea, btw!).
Bad news: core20 is amd64 only. But the i386 snap has ~100 active users and I'd rather not leave them unsupported. So, considering/trying alternatives:

• Go back to core18 and use the kde-neon PPA.
• Go back to core18 and depend on the KF5 content snap.

[maxiberta]

Update: the snap on edge is now based on core18 + kde-neon (Qt 5.14.2) - both amd64 and i386.