Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #117 corollary - if QUAL is . set to 0 #131

Merged
merged 4 commits into from Mar 20, 2024
Merged

Fix #117 corollary - if QUAL is . set to 0 #131

merged 4 commits into from Mar 20, 2024

Conversation

dnil
Copy link
Contributor

@dnil dnil commented Mar 20, 2024

This PR adds | fixes:

  • Sentieon TNscope may set QUAL to . in addition to not outputting GQ for variants. Solve by setting gq 0 for these.

How to prepare for test:

  • ssh to ...
  • Install on stage:
    bash servers/resources/SERVER.scilifelab.se/update-[THIS_TOOL]-stage.sh [THIS-BRANCH-NAME]

How to test:

  • load case with . in QUAL (e.g. selectbison)

Expected outcome:

  • works with patch, not with master

Review:

  • Code approved by HS, VI
  • Tests executed by DN
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link
Collaborator

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

loqusdb/build_models/variant.py Outdated Show resolved Hide resolved
loqusdb/build_models/variant.py Outdated Show resolved Hide resolved
Copy link

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯 , thanks @dnil!

loqusdb/build_models/variant.py Outdated Show resolved Hide resolved
loqusdb/build_models/variant.py Show resolved Hide resolved
dnil and others added 2 commits March 20, 2024 11:45
Co-authored-by: Henrik Stranneheim <henrik.stranneheim@scilifelab.se>
Co-authored-by: Henrik Stranneheim <henrik.stranneheim@scilifelab.se>
@dnil
Copy link
Contributor Author

dnil commented Mar 20, 2024

✅ Tested on loqusdb-stage.

❌ with 2.7.3:

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_loqusdb -t loqusdb -b 2.7.3
loqusdb-somatic load --case-id selectbison --variant-file SNV.somatic.selectbison.tnscope.clinical.filtered.pass.vcf.gz --sv-variants SV.somatic.selectbison.svdb.clinical.filtered.pass.vcf.gz --qual-gq

Screenshot 2024-03-20 at 11 39 40

✅ with this branch:

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_loqusdb -t loqusdb -b qual_dot
loqusdb-somatic load --case-id selectbison --variant-file SNV.somatic.selectbison.tnscope.clinical.filtered.pass.vcf.gz --sv-variants SV.somatic.selectbison.svdb.clinical.filtered.pass.vcf.gz --qual-gq

Screenshot 2024-03-20 at 11 44 39

@dnil dnil merged commit 17731f7 into master Mar 20, 2024
2 checks passed
@dnil dnil deleted the qual_dot branch March 20, 2024 10:59
@dnil
Copy link
Contributor Author

dnil commented Mar 20, 2024

Deployed to prod:
Screenshot 2024-03-20 at 13 58 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants