Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot says user ID instead of user name when there's a mention. #51

Closed
TheCrafters001 opened this issue Oct 4, 2021 · 10 comments
Closed
Labels
Priority: Medium This is medium priority. Type: Bug This is a bug report.

Comments

@TheCrafters001
Copy link

πŸ˜• Question

Hi. I noticed that whenever someone pings another user, it plays their User ID instead of just saying their name? Is there any way to prevent this?

❓ Additional Information

No other additional information.

@TheCrafters001 TheCrafters001 added the Type: Question This is just a question. label Oct 4, 2021
@moonstar-x
Copy link
Owner

As of right now this is the normal behavior. Mentions are received as the user ID which is why the bot is saying the user ID instead of their name.

I don't know if it would be worth to parse the mentions so the bot says their name instead of their ID since you can essentially just write their name instead of mentioning them. Is there a reason why you mention the user rather than just writing their name?

@TheCrafters001
Copy link
Author

As of right now this is the normal behavior. Mentions are received as the user ID which is why the bot is saying the user ID instead of their name.

I don't know if it would be worth to parse the mentions so the bot says their name instead of their ID since you can essentially just write their name instead of mentioning them. Is there a reason why you mention the user rather than just writing their name?

I self-host the bot in a few servers, and sometimes some people tend to ping people on purpose, with the intent of saying the whole user id instead. It isn't a major issue, but for those who don't want to talk, it can get very annoying very fast.

@moonstar-x
Copy link
Owner

I see, so you would expect the bot to say their name instead of their ID, right?

@TheCrafters001
Copy link
Author

I see, so you would expect the bot to say their name instead of their ID, right?

Correct.

@moonstar-x
Copy link
Owner

moonstar-x commented Oct 4, 2021

Ok, I'm gonna put this as a bug report and try to get it done. I'll see if I can do it this week cause I've been quite busy :(

@moonstar-x moonstar-x changed the title Is there a way to prevent this from saying the User ID when someone gets pinged? Bot says user ID instead of user name when there's a mention. Oct 4, 2021
@moonstar-x moonstar-x added Priority: Medium This is medium priority. Type: Bug This is a bug report. and removed Type: Question This is just a question. labels Oct 4, 2021
@TheCrafters001
Copy link
Author

Ok, I'm gonna put this as a feature request and try to get it done. I'll see if I can do it this week cause I've been quite busy :(

Alright! Take your time. I am in no big rush to get it fixed. :)

@LackyPal
Copy link

LackyPal commented Oct 4, 2021

If you plan to do this, then add some more features like this. Like emoji name instead of emoji id, channel name instead of channel id...

@LackyPal
Copy link

A simple solution for this issue which is not the best but good. There is mesage.cleanContent

we may use this on say command

const content = mesage.cleanContent.slice(`${this.client.prefix}say`.length);
ttsPlayer.say(content, GoogleProvider.NAME);

@moonstar-x
Copy link
Owner

Hi, thanks again for the suggestion.

I still haven't found enough time to work on this, I'm waiting for my semester to end in about 3 weeks so I can work on this.

In any case, as you may have seen from issue #54, all commands will be updated into slash commands and that means no message event handler.

@moonstar-x moonstar-x added the Status: In Progress Currently working on this. label Jan 19, 2022
@moonstar-x moonstar-x mentioned this issue Jan 21, 2022
1 task
@moonstar-x
Copy link
Owner

Fixed in #58.

@moonstar-x moonstar-x removed the Status: In Progress Currently working on this. label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This is medium priority. Type: Bug This is a bug report.
Projects
None yet
Development

No branches or pull requests

3 participants