Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Diamond contracts which do not mount the DiamondLoupeFacet #2

Closed
zomglings opened this issue Apr 18, 2022 · 1 comment · Fixed by #6
Closed

Add support for Diamond contracts which do not mount the DiamondLoupeFacet #2

zomglings opened this issue Apr 18, 2022 · 1 comment · Fixed by #6
Labels
enhancement New feature or request

Comments

@zomglings
Copy link
Contributor

If a diamond contract does not mount the DiamondLoupeFacet (which allows for on-chain inspection of attached functionality), then we need to crawl blockchain events to understand what functionality is mounted on that contract.

It should be possible for a user to provide us with a file of diamond-related events for a diamond contract and get all the benefits of Inspector Facet for the inspection of those events.

@zomglings zomglings added the enhancement New feature or request label Apr 18, 2022
@zomglings
Copy link
Contributor Author

A good way to proceed on this issue would be to define an interface in which events should be passed to Inspector Facet. Then, users can use whatever tool they like to crawl events from the blockchain for Inspector Facet to analyze.

For the Moonstream team, the easiest tool to use for the crawling is moonworm. moonworm watch crawls events into a JSONL (JSON lines) file which would be a good format for the input file.

This was referenced Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant