Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect list of UNIVERSAL methods rather than hard coding list #183

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

haarg
Copy link
Member

@haarg haarg commented Jul 21, 2023

We don't need to keep our own list of methods in UNIVERSAL, we can just use the actual list of methods that exists. Some things, like the import method, could end up existing based on the perl version or based on a prerequite loading UNIVERSAL.pm. There isn't really any value in keeping a hard coded list.

We don't need to keep our own list of methods in UNIVERSAL, we can just
use the actual list of methods that exists. Some things, like the import
method, could end up existing based on the perl version or based on a
prerequite loading UNIVERSAL.pm. There isn't really any value in keeping
a hard coded list.
@haarg haarg force-pushed the haarg/fix-universal-method-list branch from 423f14d to 8a42016 Compare July 21, 2023 20:03
@karenetheridge karenetheridge merged commit 2c6ca76 into master Jul 22, 2023
@karenetheridge karenetheridge deleted the haarg/fix-universal-method-list branch July 22, 2023 23:58
karenetheridge added a commit that referenced this pull request Jul 23, 2023
  [TESTS]

  - adjust the expected list of UNIVERSAL methods, to account for changes in
    perl 5.39.1 (some things, like the import method, could end up existing
    based on the perl version or based on a prerequite loading UNIVERSAL.pm).
    (#183, Graham Knop)
@pghmcfc
Copy link

pghmcfc commented Jul 23, 2023

This looks to be breaking the test with perl older than 5.22. For example, I'm getting this with 5.20.3:

t/cmop/metaclass_incompatibility_dyn.t ........................... ok
t/cmop/metaclass_inheritance.t ................................... ok
t/cmop/metaclass_loads_classes.t ................................. ok
t/cmop/metaclass_reinitialize.t .................................. ok
t/cmop/method.t .................................................. ok
t/cmop/method_modifiers.t ........................................ ok
"no" not allowed in expression at t/cmop/methods.t line 202, at end of line
BEGIN not safe after errors--compilation aborted at t/cmop/methods.t line 202.
t/cmop/methods.t .................................................
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run
t/cmop/modify_parent_method.t .................................... ok
t/cmop/new_and_clone_metaclasses.t ............................... ok
t/cmop/null_stash.t .............................................. ok
t/cmop/numeric_defaults.t ........................................ ok

@haarg
Copy link
Member Author

haarg commented Jul 23, 2023

Fixed in master. New release will come soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants