remove test checking namespace::autoclean against Test::CleanNamespaces #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was using namespace::autoclean to clean a namespace, then checking that it was cleaned via Test::CleanNamespaces. This essentially ends up only being a test of the external modules, not anything about Moose itself. Both modules are using Moose to get the list of methods. If that method list was wrong, the test would still pass because the same list is being provided to both modules. And Moose's tests don't need to include tests that are only of external modules.
karenetheridge
added a commit
that referenced
this pull request
Jan 21, 2024
[TESTS] - remove test dependency on Test::CleanNamespaces (#184, Graham Knop)
karenetheridge
force-pushed
the
master
branch
from
e79a7d8
to
d45b381
Compare
|
thanks, shipped in 2.2207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was using namespace::autoclean to clean a namespace, then checking that it was cleaned via Test::CleanNamespaces. This essentially ends up only being a test of the external modules, not anything about Moose itself. Both modules are using Moose to get the list of methods. If that method list was wrong, the test would still pass because the same list is being provided to both modules. And Moose's tests don't need to include tests that are only of external modules.