disable Request onTimeout with async = false

[kguelzau]

Timeout handling does not work with "async: false".
onTimeout is triggered always after xhr.send() returns.

Here is a testcase:
http://jsfiddle.net/kguelzau/thxA4/

Should be

if (!this.options.async) this.onStateChange();
**else** if (this.options.timeout) this.timer = this.timeout.delay(this.options.timeout, this);

[ibolmo]

worksforme.

Here's the deal. If you set async to false then the method Request.send is blocked by line 199 because you asked that it should (remember the async false?).

Since send is blocked and eventually fires the events (e.g. onSuccess) and then sets up the delay, but by then send is all done and the request has already finished.

Re-open if you have another problem.

[kguelzau]

I don't have the permission to reopen.

It's OK that Request.send is blocking with async=false.
But it doesn't make any sense to me to trigger the timeout delay if i already know that the request definitely has already been finished.
So one option is to remove timeout handling completely (what i suggested) or to start the delay right before send.

[ibolmo]

Ah I see what you mean, but I think the options are mutually exclusive. You either do async: false or you do timeout: 1000.

If you do async: false the XHR transport will rely on server timeout or browser set timeout (internal to the transport, or perhaps a blocking protection which will prompt user to kill the javascript that is blocking) to return execution to the script.

I've reopened this issue as a documentation issue. Do you agree?

[ibolmo]

@arian @cpojer, we could still reduce headaches if we do as @kguelzau mentioned. To add an else if. If you guys agree with my last comment, I don't see a problem of adding that else if on this line.

[cpojer]

√