contains causes "Out of Stack Space" in IE #2248

Closed
trichins opened this Issue Jan 23, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@trichins

If you go to mootools.net in IE9, open up the developer tools, go to the console and enter the string "document.contains($('header'))' you'll get an error "Out of stack space".

@arian

This comment has been minimized.

Show comment
Hide comment
@arian

arian Feb 5, 2012

Member

This is a Slick issue.

I've looked into this. The problem is that it checks if document.documentElement exists and is the native contains method.
IE however does not have document.contains. So MooTools will set it with a Slick.contains wrapper. Now when you call document.contains it will result in an infinite recursion.

Probably an extra check should be added if document.contains is a native method.

Member

arian commented Feb 5, 2012

This is a Slick issue.

I've looked into this. The problem is that it checks if document.documentElement exists and is the native contains method.
IE however does not have document.contains. So MooTools will set it with a Slick.contains wrapper. Now when you call document.contains it will result in an infinite recursion.

Probably an extra check should be added if document.contains is a native method.

@ghost ghost assigned arian Feb 5, 2012

@arian

This comment has been minimized.

Show comment
Hide comment
@arian

arian Feb 5, 2012

Member
Member

arian commented Feb 5, 2012

@arian

This comment has been minimized.

Show comment
Hide comment
@arian

arian Feb 5, 2012

Member

This is fixed in Slick now.

Member

arian commented Feb 5, 2012

This is fixed in Slick now.

@arian arian closed this Feb 5, 2012

@ibolmo

This comment has been minimized.

Show comment
Hide comment
@ibolmo

ibolmo Feb 6, 2012

Member

Committed: a9c73ce

Member

ibolmo commented Feb 6, 2012

Committed: a9c73ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment