Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loglevels/* has no effect on mopidy.log #1382

Closed
jcass77 opened this issue Jan 2, 2016 · 6 comments
Closed

loglevels/* has no effect on mopidy.log #1382

jcass77 opened this issue Jan 2, 2016 · 6 comments
Labels
A-docs Area: Documentation C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal

Comments

@jcass77
Copy link
Member

jcass77 commented Jan 2, 2016

The loglevels/* configuration as currently documented can probably be refined a little in the following respects:

  1. the documentation should make it clear that the configuration parameters can only be used to reduce the log levels of specific modules, not increase it. In other words, one should set the root logger to the highest level, and then reduce everything except the module that you would like to debug to something like INFO.
  2. the configuration parameters only have an effect on what is being logged to the console. Now that most users (at least everybody using the Pi Musicbox) are probably running Mopidy as a service, it may make sense to also apply the settings to the output that goes to the mopidy.log file as well.

I can take a stab at creating a PR for this if there is general agreement on the above?

@adamcik
Copy link
Member

adamcik commented Jan 5, 2016

  1. I fully agree, and have often been annoyed by this. Not a 100% sure how to solve this in a sane way when we don't know the logger names up front. But it sounds like you want it to work the same way I think it should :-)
  2. Sounds reasonable. Only catch I can think of is how this interacts with the log config file thing we still support as an escape hatch for doing whatever you want with the logging setup.

@adamcik adamcik added the C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal label Jan 5, 2016
@kingosticks
Copy link
Member

I'm all for both these enhancements.

@jcass77
Copy link
Member Author

jcass77 commented Jan 7, 2016

This Mopidy discuss thread has reference.

If the long term goal is to do away with logging.conf and --save-debug-log and rely solely on stdout, then loglevels/* will actually be fine the way it is.

Should we park this issue in anticipation of transitioning to systemd and journals in some future release of Mopidy?

@jodal jodal added A-docs Area: Documentation A-core Area: Core layer labels Jan 17, 2016
@jodal
Copy link
Member

jodal commented Jan 17, 2016

@adamcik Any comments after reading the discuss thread?

@jodal
Copy link
Member

jodal commented Feb 16, 2016

@jcass77 Assuming #1452 is implemented, the remaining part in this issue is just better docs for the loglevels config section?

@jodal jodal removed the A-core Area: Core layer label Feb 16, 2016
@jcass77
Copy link
Member Author

jcass77 commented Feb 22, 2016

Yes, we can probably close this assuming the docs will be updated as part of #1452 anyway.

@jcass77 jcass77 closed this as completed Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Development

No branches or pull requests

4 participants