Fix arbitrary file access in M3U backend #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodal
force-pushed
the
fix/m3u-arbitrary-file-access
branch
from
3a595a0
to
c01e796
Compare
jodal
force-pushed
the
fix/m3u-arbitrary-file-access
branch
from
c01e796
to
58e75b2
Compare
|
Cool! I'm on holiday this week but can review when back. |
kingosticks
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
core.playlists.delete()to be a success bool.mopidy.internal.path.is_path_inside_base_dir()to check if any received URI/path is inside them3u/playlist_dirdirectory. If not, the request is treated as if the path doesn't exist.This should plug the last part of #1659 and make us ready to release Mopidy 2.2.