Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup crash when loading invalid extensions #1990

Merged
merged 1 commit into from Jul 23, 2021
Merged

Fix startup crash when loading invalid extensions #1990

merged 1 commit into from Jul 23, 2021

Conversation

DavisNT
Copy link
Contributor

@DavisNT DavisNT commented Jul 15, 2021

Fixes #1989

@jodal jodal requested a review from kingosticks July 17, 2021 12:49
@jodal jodal added this to the Next bug fix release milestone Jul 17, 2021
@kingosticks
Copy link
Member

I think I'd prefer using hasattr() or catching AttributeError to be more explicit about what we are doing and then giving a less generic error message for the specific problem of loading a totally incompatible extension... But it's not a blocker for me.

@kingosticks kingosticks added C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal needs changelog entry labels Jul 23, 2021
@kingosticks kingosticks merged commit 6d2b4b3 into mopidy:develop Jul 23, 2021
@jodal jodal modified the milestones: Next bug fix release, v3.3.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodal jodal jodal approved these changes

@kingosticks kingosticks kingosticks approved these changes

Assignees

@DavisNT DavisNT

Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Loading of some extensions causes Mopidy to crash
3 participants
@DavisNT @kingosticks @jodal