Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: Fixed optional allowed_origins config setting. #2066

Merged
merged 2 commits into from Dec 7, 2022
Merged

http: Fixed optional allowed_origins config setting. #2066

merged 2 commits into from Dec 7, 2022

Conversation

kingosticks
Copy link
Member

This was broken in #2054

@kingosticks kingosticks added the A-http Area: HTTP frontend label Dec 6, 2022
@kingosticks kingosticks added this to the Next bug fix release milestone Dec 6, 2022
@kingosticks kingosticks self-assigned this Dec 6, 2022
djmattyg007
djmattyg007 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@djmattyg007 djmattyg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure how I missed this, it was so long ago when I first worked on these changes.

@kingosticks
Copy link
Member Author

Not to worry, I should have run with -v when doing the release and noticed the warnings. We could look at adding the test I added for every extension, is useful.

@kingosticks kingosticks merged commit 5e9023e into mopidy:develop Dec 7, 2022
@kingosticks kingosticks deleted the fix/http-allowed_origins-optional branch December 7, 2022 09:55
@jodal jodal modified the milestones: Next bug fix release, v3.4.1 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmattyg007 djmattyg007 djmattyg007 approved these changes

Assignees

@kingosticks kingosticks

Labels
A-http Area: HTTP frontend
Projects
None yet
Milestone
v3.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kingosticks @djmattyg007 @jodal