Remove core.playback.play()'s tl_track argument #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodal
force-pushed
the
remove-play-tl-track
branch
4 times, most recently
from
8030395
to
35a3a08
Compare
kingosticks
requested changes
Feb 25, 2024
jodal
force-pushed
the
remove-play-tl-track
branch
from
35a3a08
to
ce533f0
Compare
kingosticks
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument has been deprecated since Mopidy 3.0, released more than four years ago.
I don't know how much this argument is used by frontends/clients. However, the migration path is straight forward as any caller can replace:
With:
Or, to keep compatibility with Mopidy < 4.0:
The recently added type hints should also be of help when migrating frontends/clients.
Part of #1855