Remove loglevels functionality

[jodal]

As it can only be used to decrease the amount of logging from a sublogger, not increase it, this feature is barely useful as currently implemented.

[jodal]

@txomon claimed that the loglevels functionality can be used by increasing the verbosity of everything, then reducing the verbosity explicitly on e.g. the mopidy logger, and then increasing the verbosity of a specific backend or similar. In concrete terms:

mopidy -v -o loglevels/mopidy=info -o loglevels/mopidy.mpd=debug

...should give you debug logging for mopidy.mpd and nothing else.

I've tried this, and it doesn't seem to work on v0.17.0 (pre the recent log setup changes) or on v0.18.1. Thus, I'm still claiming that we should remove the loglevels config section.

[adamcik]

I believe something along the lines of the following should do the trick. We could even refactor this further putting mopidy, mopidy_* and root values in the loglevels dict if done right.

I.e. I think we should reconsider if keeping this is as simple as the diff below.

diff --git a/mopidy/utils/log.py b/mopidy/utils/log.py
index 6004b9f..c3a6a3d 100644
--- a/mopidy/utils/log.py
+++ b/mopidy/utils/log.py
@@ -62,10 +62,15 @@ LOG_LEVELS = {


 class VerbosityFilter(logging.Filter):
-    def __init__(self, verbosity_level):
+    def __init__(self, verbosity_level, loglevels):
         self.verbosity_level = verbosity_level
+        self.loglevels = loglevels

     def filter(self, record):
+        for name, required_log_level in self.loglevels.items():
+            if record.name == name or record.name.startswith(name + '.'):
+                return record.levelno >= required_log_level
+
         if record.name.startswith('mopidy'):
             required_log_level = LOG_LEVELS[self.verbosity_level]['mopidy']
         else:
@@ -79,7 +84,7 @@ def setup_console_logging(config, verbosity_level):
     if verbosity_level > max(LOG_LEVELS.keys()):
         verbosity_level = max(LOG_LEVELS.keys())

-    verbosity_filter = VerbosityFilter(verbosity_level)
+    verbosity_filter = VerbosityFilter(verbosity_level, config['loglevels'])

     if verbosity_level < 1:
         log_format = config['logging']['console_format']

[jodal]

I was just about to push the removal of this, but your fix seems beautifully simple. I'll give it a try.

[jodal]

Fixed by 40cadbf.

[txomon]

Thanks!!! I promise I use it!! I will do a nice use of it :)

[jodal]

Related fixes: 1ef1116 and 5551d09.