Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local libraries don't list albums in search #920

Closed
joemarshall opened this issue Dec 24, 2014 · 3 comments
Closed

Local libraries don't list albums in search #920

joemarshall opened this issue Dec 24, 2014 · 3 comments
Labels
C-bug Category: This is a bug

Comments

@joemarshall
Copy link

The way the local libraries are written, they only return tracks, so a search for an album in e.g. musicbox webclient returns just tracks.

@adamcik adamcik added Local C-bug Category: This is a bug labels Dec 28, 2014
@tkem
Copy link
Member

tkem commented Jan 3, 2015

Probably depends on #840

@joemarshall
Copy link
Author

It relates to something mentioned in that, in that the current local backend doesn't support lookup of albums or artists, which means that searchresults with them in aren't so useful.

The existingsqlite backend does support lookup of albums and artists in the browse structure, but the search function in that has no way of returning albums and artists.

If the local backend a)returns albums and artists for search results, and b)returns lookup-able URIs to them, then it works great in clients such as musicbox web client - I implemented this, amongst other things in the pull request below, and it works great (although I can see the PR might need some messing before it is good enough to merge)
#921

One gotcha is that the popular musicbox webclient has what I think is a bug with quoting of URIs when you click on an album name.
pimusicbox/mopidy-musicbox-webclient#62

@adamcik
Copy link
Member

adamcik commented Mar 17, 2015

Given the plans to do #1003 I doubt we will bother fixing this in the JSON backend. Though if someone adds this to the json search results in a reasonable way, we would consider merging it despite the plan to move local out of the main project.

@adamcik adamcik closed this as completed Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants