Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in second example in section 6.3.4 of draft-03 #415

Open
englishm opened this issue Mar 14, 2024 · 1 comment
Open

Errors in second example in section 6.3.4 of draft-03 #415

englishm opened this issue Mar 14, 2024 · 1 comment
Labels
Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations. Needs PR

Comments

@englishm
Copy link
Contributor

There are two issues with this example:

Sending a group on one stream, with a unordered object in the group appearing
on its own stream.
~~~
Stream = 2
STREAM_HEADER_GROUP {
Subscribe ID = 2
Track Alias = 2
Group ID = 0
Object Send Order = 0
}
{
Object ID = 0
Object Payload Length = 4
Payload = "abcd"
}
{
Object ID = 1
Object Payload Length = 4
Payload = "efgh"
}
Stream = 6
OBJECT_STREAM {
Subscribe ID = 2
Track Alias = 2
Group ID = 0
Object ID = 1
Payload = "moqrocks"
}
~~~

  1. The Object id should be unique, not duplicated.
  2. We shouldn't be mixing different forwarding preferences within the same track, per earlier text in this same version of the draft:

Every Track has a single 'Object Forwarding Preference' and publishers
MUST NOT mix different forwarding preferences within a single track.
If a subscriber receives different forwarding preferences for a track, it
SHOULD close the session with an error of 'Protocol Violation'.

@ianswett ianswett added Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations. Needs PR labels Mar 18, 2024
@fluffy
Copy link
Contributor

fluffy commented Mar 18, 2024

Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations. Needs PR
Projects
None yet
Development

No branches or pull requests

3 participants