Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation for the first start login page #170

Closed
mckhoi opened this issue Dec 27, 2016 · 7 comments
Closed

German translation for the first start login page #170

mckhoi opened this issue Dec 27, 2016 · 7 comments

Comments

@mckhoi
Copy link

mckhoi commented Dec 27, 2016

Dear David,

I am working on the translation for the German language. Most of the words I can translate in the Localization, but I do not have any idea how to translate the text on the first login page. I can find those text in the file "Login.ftl".

Further questions:

  1. Do you know anybody working on the translation for the German language? Or there is one?
  2. If not, I would like to publish the German translation and would you please guide me, how to make it right? Right now I just inserted the translation directly into the system, but not as seed data, then restarted the system and checked.

Best regards,
Khoi Tran

@jonesde
Copy link
Member

jonesde commented Dec 27, 2016

The Login screen is a bit different from most. As you pointed out the main content is in a FTL template and not in an XML Screen so labels/titles/etc are not automatically localized. Quite a few of the FTL templates around are internationalized but it looks like Login.ftl is not yet (ie with inline calls to ec.l10n.localize()).

I'm not aware of any efforts underway or having been done for a German translation, but this isn't the best place to ask and asking me directly doesn't work as well as posting to the user and contributor community more generally. The best place to do that is in the Moqui Ecosystem group on LinkedIn.

The only localization data set I'm aware of that users of Moqui have published is for Chinese and you can see that on the Add Ons page on moqui.org:

http://moqui.org/addons.html

@jonesde
Copy link
Member

jonesde commented Dec 27, 2016

BTW, this is really an issue for the moqui-runtime repository as that is where the Login.ftl screen lives. The main framework code (in the moqui-framework repository) intentionally knows nothing about the HTML/etc to use when rendering screens, that is all in the default runtime and wouldn't apply if you use a custom runtime directory and a root screen other than the webroot.xml screen that is part of moqui-runtime.

One other point about this: before login we don't know who the user is so we don't have the locale specified for their account. With no user authenticated the l10n stuff uses the default server locale. We could try looking at the locale sent with the request if the user has a locale set in their browser.

@mckhoi
Copy link
Author

mckhoi commented Dec 27, 2016

User can set the default language for their login page, as they want to. Many systems just work this way, user can change the language at the start. User gets trust right at the first page, if they can understand.

Here, I think we can map the setting language at start to the user setting, if the login is successful?

@mckhoi
Copy link
Author

mckhoi commented Dec 27, 2016

Another idea without setting default language at the first page.
The mobile login for future like whatsapp web. Moqui creates QR-Code and the mobile device just scans and Moqui can adopt the local setting of the mobile. ;-)

@mckhoi
Copy link
Author

mckhoi commented Dec 27, 2016

There is a small add-on component for the German translation.
https://github.com/mckhoi/moqui-de_DE-addon

Thanks David.

@jonesde
Copy link
Member

jonesde commented Jan 8, 2017

Great, helpful to have shared translation components like that. I added it to the list on http://moqui.org/addons.html

@jonesde
Copy link
Member

jonesde commented Jan 17, 2018

Closing as part of general cleanup for the move to HiveMind and for no recent activity on this issue. If this comes up again or you want to pursue it feel free to create a request on moqui.org. For more information see:

https://www.moqui.org/m/docs/moqui/Community+Guide

@jonesde jonesde closed this as completed Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants