Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit permission #9

Closed
lucaspedrazoli opened this issue Oct 11, 2018 · 3 comments
Closed

Inherit permission #9

lucaspedrazoli opened this issue Oct 11, 2018 · 3 comments
Assignees
@moraisandre
Labels
enhancement

Comments

@lucaspedrazoli
Copy link

we could change the SwiftMaskField class to open instead of public to permit inherit
@moraisandre moraisandre self-assigned this Oct 16, 2018
@moraisandre
Copy link
Owner

Hey Lucas Pedrazoli,

Why do you want to inherit the SwiftMaskField? There is any good reason for it? cuz I can't think of any

@lucaspedrazoli
Copy link
Author

Because with inherit we can create a Visual Component, and these components can have reusable properties and functionalities. Let's suppose all text field that uses mask will have a red border bottom. If the system have a class to inherit I wont need to always add this border.

@moraisandre
Copy link
Owner

Hey thanks for the explanation, I've changed and already pushed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moraisandre moraisandre

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucaspedrazoli @moraisandre