Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a download button for lay users in the Readme file #33

Closed
Heus-Sueh opened this issue May 31, 2023 · 8 comments
Closed

Add a download button for lay users in the Readme file #33

Heus-Sueh opened this issue May 31, 2023 · 8 comments

Comments

@Heus-Sueh
Copy link

same as decky-loader Readme button
we could ask if we can use this image of them
image

Decky Loader Readme RAW

@moraroy
Copy link
Owner

moraroy commented May 31, 2023

Thank you @Heus-Sueh for the suggestion! @cchrkk what do you think should we add that?
Also thank you brother for the Kofi! I saw it on my email you didn't have to! I should be giving you the cup of coffee lol. Another thing on my mind as well, the log file is good I like it makes it very easy but I noticed a problem. I ran the script like 20 times yesterday trying to test some things and I noticed the log file "builds" and gets bigger with code. When steam restarts the log seems to keep logging even after the script is finished. It may be because I need to put an "exit" at the end of the script not sure if that's the problem or not... what do you think?

@cchrkk
Copy link
Contributor

cchrkk commented May 31, 2023

Here we go 👌👌 #35
I knew there was a way to make a button to auto download it, i'm too noob to undestand stuff :D

@moraroy don't worry bro, your script idea is super handy and convenient. You're super invested into fixing issues and implementing stuff and u deserved a coffee 💯

Try to add exit and see, I know zero of programming not even bash, I'm just a geek 🤣

cchrkk added a commit to cchrkk/NonSteamLaunchers-On-Steam-Deck that referenced this issue May 31, 2023
I will not delete my fork this time
moraroy added a commit that referenced this issue Jun 1, 2023
Added download logo as asked in #33
@cchrkk
Copy link
Contributor

cchrkk commented Jun 1, 2023

I just noticed it's not working anymore, to be able to download the desktop file instead of opening it in the browser, you must link to some file in the Release section. So you probably need to create a new repository and release the .desktop file there, then link it. 😒 Why is it so hard to link and download a file

@cchrkk
Copy link
Contributor

cchrkk commented Jun 1, 2023

Fixed temporarily by #36 but maybe you want to create a DL repository yourself

@moraroy
Copy link
Owner

moraroy commented Jun 1, 2023

@cchrkk nice work! Yeah I noticed that too but I'm thinking maybe we won't need the .desktop file anymore since we have that button now.. but in the end I guess the more ways to download the better?

@moraroy
Copy link
Owner

moraroy commented Jun 1, 2023

@cchrkk thats a tight logo BRO!!!!! <3

@cchrkk
Copy link
Contributor

cchrkk commented Jun 1, 2023

@cchrkk nice work! Yeah I noticed that too but I'm thinking maybe we won't need the .desktop file anymore since we have that button now.. but in the end I guess the more ways to download the better?

Uhm, that button is linked to the desktop file 😂 That button didn't work for the last 20 hours.

@cchrkk thats a tight logo BRO!!!!! <3

Thank you :) spent a good hour for that

@Heus-Sueh
Copy link
Author

thanks 👍 @cchrkk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants