Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing assets throughout tests #111

Closed
adamrt opened this issue Nov 9, 2023 · 2 comments
Closed

Missing assets throughout tests #111

adamrt opened this issue Nov 9, 2023 · 2 comments
Labels
assets Assets location or information about them question Further information is requested

Comments

@adamrt
Copy link

adamrt commented Nov 9, 2023

Hi I always checkout out cool renderers when I see them. I went to test RendererGL but the majority of the tests have hard links to models on your local machine (example).

In the interest of not being lazy I tried to track them down and was going to create a PR, but I'm unable to find most of them.

I was able to find Block City, but most others weren't as obvious. Any change you will commit the assets to the repo and make the paths relative? Or if you zip up that models folder I'd be happy to send a PR with relative paths.

No worries either way. Very cool project!

@MorcilloSanz
Copy link
Owner

Hello, thank you very much for your words.

The main reason why I don't upload the test assets is because I don't know the origin of some of them and therefore their license.
For that reason I left the absolute paths, so that it serves as an example for the users.

In case it is useful, I downloaded most of them from https://www.models-resource.com
And in the case of the PBR test, I downloaded the textures from: https://freepbr.com

What I would do would be to download the ones I find most interesting and substitute the routes in the test. You can take advantage of the Block City model since you have found it.

Thanks in advance.

@MorcilloSanz MorcilloSanz added the question Further information is requested label Nov 9, 2023
@adamrt
Copy link
Author

adamrt commented Nov 10, 2023

Thanks Morcillo, that's helpful and makes a lot of sense about the license. I'll spend some time getting them going this weekend. Keep up the awesome work!

@adamrt adamrt closed this as completed Nov 10, 2023
@MorcilloSanz MorcilloSanz added the assets Assets location or information about them label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Assets location or information about them question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants