You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #38, I suggested that chunked should match grouper. What I didn't realize at the time is that the signature for grouper doesn't match what's in the stdlib docs. Here's what I see for stdlib:
But the signature for the implementation herein switches the order of parameters.
I'd have expected the recipes to match the documentation in the stdlib... or at least call out when the signature doesn't match. Best would be for it to match so that someone doesn't read the stdlib docs, find the recipe they need, pull in more-itertools to use it, then find that it's not implemented that way in more_itertools.
Did the order of the parameter change in the stdlib recipe?
Would you consider a pull request to give compatibility for either order of parameters and raise a DeprecationWarning when they're not in the new, preferred order as found in stdlib docs?
The text was updated successfully, but these errors were encountered:
In #38, I suggested that chunked should match grouper. What I didn't realize at the time is that the signature for
grouper
doesn't match what's in the stdlib docs. Here's what I see for stdlib:But the signature for the implementation herein switches the order of parameters.
https://github.com/erikrose/more-itertools/blob/1a3682b87a78416711fdeea7ef050e997d5e4e4b/more_itertools/recipes.py#L288-L296
I'd have expected the recipes to match the documentation in the stdlib... or at least call out when the signature doesn't match. Best would be for it to match so that someone doesn't read the stdlib docs, find the recipe they need, pull in more-itertools to use it, then find that it's not implemented that way in more_itertools.
Did the order of the parameter change in the stdlib recipe?
Would you consider a pull request to give compatibility for either order of parameters and raise a DeprecationWarning when they're not in the new, preferred order as found in stdlib docs?
The text was updated successfully, but these errors were encountered: