Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add when-prop in the vein of react-reveal #14

Closed
ljosberinn opened this issue Dec 14, 2019 · 5 comments
Closed

Add when-prop in the vein of react-reveal #14

ljosberinn opened this issue Dec 14, 2019 · 5 comments

Comments

@ljosberinn
Copy link

Hi,

first, let me thank you for this modern alternative to react-reveal! Was mostly a plug- & play-replacement process.

However, one feature I'd like to see is missing: the when prop.

Example use case:

  • login form shakes on error: <Shake when={!!error}>{children}</Shake>
@morellodev morellodev added the enhancement New feature or request label Dec 15, 2019
@morellodev
Copy link
Owner

Hi @ljosberinn,

stay tuned for future updates 🚀

@PeterKottas
Copy link

Bump on this.

@morellodev
Copy link
Owner

Hi,

you can use the reverse prop as a temp workaround by binding it to a state variable of your component.

I have no plan to implement the when prop in the near future, but you can submit a PR if you would implement this in a performant way :)

@morellodev morellodev added the help wanted Extra attention is needed label Jan 26, 2020
@PeterKottas
Copy link

So let me see if I understand this. If you provide reverse={true}, it simply cancels/rewinds the already visible animation? I think it might be somewhat counterintuitive and the when props seem like a more straight forward solution. I personally don't need it, but it's reasonable to expect somebody who does to bring it on board. It's open-source after all ;)

@morellodev morellodev removed enhancement New feature or request help wanted Extra attention is needed labels Oct 16, 2020
@morellodev
Copy link
Owner

This is out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants