Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate css in the bundle #27

Closed
PeterKottas opened this issue Jun 15, 2020 · 3 comments
Closed

Animate css in the bundle #27

PeterKottas opened this issue Jun 15, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@PeterKottas
Copy link

PeterKottas commented Jun 15, 2020

The entire animate.css is included as a string in the package, consequently making the library unnecessarily large. After reading this, I kind of understand why this was done, but this is quite a disaster for ssr and statically generated pages. My generated HTML pages grew by 50% after adding this lib because the style is inline loaded (yet the same code also remains in the js that needs to be downloaded subsequently). I think it would make sense to make this optional. Including this directly in the source is not a good idea IMHO. I for one would prefer if I could take care of this on my end, maybe even pick only the parts of animate.css that I am interested in.

@morellodev
Copy link
Owner

Hi @PeterKottas,

I agree with you. I am going to release a new major version with a per-component CSS handling, so to minimize the amount of styling rules included in the final bundle.

@morellodev morellodev added the enhancement New feature or request label Jun 15, 2020
@morellodev morellodev self-assigned this Jun 15, 2020
@PeterKottas
Copy link
Author

Lovely! Looking forward to that, glhf! :)

@morellodev
Copy link
Owner

Version 3 featuring CSS-in-JS animations is now on beta, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants