Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md should mention git commit style #279

Closed
jayvdb opened this issue Jul 8, 2019 · 2 comments
Closed

CONTRIBUTING.md should mention git commit style #279

jayvdb opened this issue Jul 8, 2019 · 2 comments
Labels

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 8, 2019

This repo uses emoji's in commit messages. Newcomers should be given hints on how to do that.

And old-comers also forget which emoji's to use for various situations.

There are a few so good time to make sure the current one is the best

@jayvdb
Copy link
Member Author

jayvdb commented Jul 8, 2019

https://github.com/moremoban/moban/search?q=emoji&unscoped_q=emoji shows emoji isnt mentioned anywhere yet, except this issue now

@jayvdb
Copy link
Member Author

jayvdb commented Jul 8, 2019

@jayvdb jayvdb added the docs label Jul 18, 2019
@chfw chfw closed this as completed in 9d28ccd Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant