Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weapon proficiencies migration from old pdf to 12-95 #13

Closed
erickrause opened this issue Apr 23, 2017 · 3 comments
Closed

weapon proficiencies migration from old pdf to 12-95 #13

erickrause opened this issue Apr 23, 2017 · 3 comments

Comments

@erickrause
Copy link
Contributor

I have a level 1 fighter that I built with a pdf in the last month. Not sure which version of the pdf. I tried the import into the latest pdf and none of the weapon and armor proficiencies moved across.

I also just noticed that the Variant Human didn't come across. The text was all set correctly, but I had to reselect it for the description in the ability score Javascript window.

Also, it's the print friendly version for both.

@morepurplemorebetter
Copy link
Owner

morepurplemorebetter commented Apr 24, 2017

In order for me to have any idea where to start looking into this bug, I would have to know the version number of the sheet you are importing from. You can find the version number on the bottom over every page, and in the document's properties (File >> Properties... Ctrl+D).

However, I tried to reproduce this issue with several version of the sheet now and can't find anything that is going wrong like you describe. So it might just be best if you can send me a copy of the sheet you are trying to import from.

EDIT: Also very important is to know what method of importing you use. Do you use the recommended method of "Import Directly from a PDF"? Or do you first make an .xfdf export of the old sheet that you then import?

@erickrause
Copy link
Contributor Author

I'm sorry I couldn't find the version number before. I forgot that it was on the bottom of the page.
MorePurpleMoreBetter's D&D 5th edition Character Record Sheet v12.93 (Printer Friendly - Redesign)
This was the one imported into:
MorePurpleMoreBetter's D&D 5th edition Character Record Sheet v12.95 (Printer Friendly - Redesign)

I've been doing my migrations using the Import Directly from PDF ever since I saw the chance in the Changelog

I can't seem to be able to recreate the proficiencies migration bug. I'm sorry you spent any time running that down.

I am still seeing the variant Human Racial Trait not come across as selected. The text is correct, but the option under Racial Options isn't correct. As far as I can tell this only impacts the text on the Ability Score Window.

Again, I'm sorry you spent the time trying to run down a bug that I can't reproduce now.

I've attached my sheet that I was importing from should you want to take a look.

Talen (Eric).pdf

@morepurplemorebetter
Copy link
Owner

Thank you for giving some more details about the Variant Human bug. I was able to recreate it and I found a way to fix it. You can expect it to be patched in the next version of the sheet!

And I guess we will call the proficiencies not importing a fluke ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants