Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French flavor fixes #145

Open
rogerburks opened this issue Feb 16, 2022 · 1 comment
Open

French flavor fixes #145

rogerburks opened this issue Feb 16, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rogerburks
Copy link
Collaborator

In event 99949 "The Death of Henri Riviere" leads directly to 99955, which costs France full establish_protectorate_casus_belli infamy (20 infamy). Because it is a chain of events, each with only one option, the player has no warning or choice about this infamy cost:

FROM = {
war = {
target = THIS
attacker_goal = { casus_belli = establish_protectorate_casus_belli }
defender_goal = { casus_belli = status_quo }
call_ally = no
}
}

The solution to this and other such problems is to grant a casus belli before using war. This results in a lack of infamy cost.

I have decided to go over the code in an attempt to find all other events that incur this unavoidable infamy cost. One known case is addressed separately in #137. I will go through a French playthrough to find out if any additional hidden infamy occurs.

@rogerburks rogerburks self-assigned this Feb 16, 2022
@rogerburks rogerburks added bug Something isn't working WIP Ready for discussion but not merging labels Feb 16, 2022
@rogerburks rogerburks changed the title Hidden infamy cost in flavor war events French flavor fixes Feb 17, 2022
@rogerburks rogerburks removed the WIP Ready for discussion but not merging label Feb 17, 2022
@rogerburks
Copy link
Collaborator Author

rogerburks commented Feb 17, 2022

I did not find any additional hidden infamy, but I did find some other minor problems. It seemed best to address them all at once:

  • louisiana_rename could never have its allow satisfied by its effect once it became allowed. This was because renamed_washington flags should have been renamed_montana flags. This suggests that the other states were meant to be renamed as well, especially because Washington state and provinces are not renamed.

  • Louisiana is misspelled a few times in localisation.

  • event 95650, "French Indochina," is a repeating event intended to award a casus belli to France for the gradual formation of French Indochina. The event would continue to fire, but would not award a casus belli, only when provinces held by SIA fit the trigger. The cause seems to be that demand_concession_BC_casus_belli is invalid for this purpose. Switching it to demand_concession_casus_belli fixes the problem. However, balancing issues remain. This is because the event could be used to demand concessions from Thailand until it is left with only its capital state. This seemed like an idea for a separate issue, since it is a balancing issue and not a bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant