Add a player option to prevent Fokker Aeroplanbau from moving Germany's capital #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where it moves the capital back and forth. This is done in the original event because that is the only way to place a factory at the desired location, although it does not always anticipate where to place the capital once it is done.If Germany has been formed by the player in an unusual way, such as with Baden, the player may not wish to have the capital moved to Berlin, for instance. This gives the player an option to refuse to move the capital.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #150
Adds an option to event
99814"Fokker Aeroplanbau," to avoid the effect where it moves the capital back and forth. This is done in the original event because that is the only way to place a factory at the desired location, although it does not always anticipate where to place the capital once it is done. If Germany has been formed by the player in an unusual way, such as with Baden, the player may not wish to have the capital moved to Berlin, for instance. This gives the player an option to refuse to move the capital.I examined other code to find other events that may do this. I found some for the United Kingdom that I left alone, because London should be the only valid option for the capital to be placed at. Other cases for Germany were vanilla decisions, which probably require a different fix and arguably are a different issue.
An ai chance is added that should choose the original option every time, so that it does not miss out on its airplane factory.