Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation entries editing #66

Open
23 of 41 tasks
moretrim opened this issue Apr 22, 2020 · 0 comments
Open
23 of 41 tasks

Localisation entries editing #66

moretrim opened this issue Apr 22, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@moretrim
Copy link
Owner

moretrim commented Apr 22, 2020

A collection of editing issues with localisation entries. Let’s put it all here rather than open one issue for every minor thing.

Improvements and tweaks

  • improve NORMAL_WAR_CONQUEST_NAME (likewise AGRESSIVE_WAR_CONQUEST_NAME), e.g. “Fifth Conquest of Belgian War” is too clumsy
  • add localisation entry for the Call Allies CB (also missing upstream in HPM)
  • correct the ever elusive gendarmerie_desc
  • correct that one Taiping victory event
  • double check longitude/latitude typography, e.g. from demand_36_parallel: 36"30' (should be: 36°30′, though the minute sign will have to be approximated)
  • missing TST_ADJ (South Tyrolean)
  • review the CB text for improper $VARIABLE$ use (e.g. war reparations)
  • change the adjective of the Papal Kingdom to Papal (instead of Italian)
  • NZL_ADJ is New Zealand, though it is a tricky case
  • IOT_ADJ is British, which is just confusing. Consider Chagossian instead (unclear if this demonym also works politically/geographically).
  • LEG_ADJ is Chinese, which is confusing
  • review SGM_ADJ which is Sigmarinian, should likely be Sigmaringer (Hohenzollern for monarchy could also match e.g. Ottoman or Tokugawa)
  • non-monarchy SGM: 1848-proposed Hohenzollern Republic from Wikipedia referencing Marx & Engels
  • RHI_ADJ: Rhenish instead of Rhinelander, the latter of which is only attested as demonym

Typos

  • Abbas said (missing uppercase) general name in a couple cultures
  • EVT6060OPTB: “This isn't out fight.”
  • AGC_adj: Angochean (Angochen)
  • SEY_adj: Seychellois (Seychelloise)
  • BUK (other than absolute monarchy): Bukhara (Bukkhara)
  • one of the socialist parties of CZH suffers from mojibake

Differences with HPM

We should consider porting:

  • AND_TRIGGER_STARTS and OR have colour, useful for highlighting the structure of complicated triggers
  • opposite pairs IS_RELIGIONIS_NOT_RELIGION and CULTURE_ISCULTURE_IS_NOT emphasise the ‘NOT’ with capitalisation where applicable, useful for improved readability
  • BRIGADES_COMPARE_GREATER, BRIGADES_COMPARE_SMALLER: missing final line break (fixed upstream in HPM)

Proper and place names

Names in English and other languages, that are spelled inconsistently or incorrectly:

  • Luxembourg (though less common, Luxemburg is also attested in English—this is strictly a matter of consistency)
  • Port-aux-Basques (capitalisation & dashes seems to vary according to convention, have to settle on one)
  • Monégasque (not “Monegasc”)
  • Coeur D'Alene (capitalisation: d’Alene)
  • St. Louis (abbreviation period, up to convention)
  • Newfoundlander (adjective)
  • Yucatán
  • Faustin Soulouque (not Faustan Soulique), from unmodded files
  • French: Réunion, Sarre et Mont-Tonnerre (mind the dash), Fréjus, Côte d’Argent (capitalisation, too) as well as other côtes, Mont-de-Marsan (mind the dashes), Légion d’honneur (capitalisation?), Neuchâtel (circumflex), Neuchâtelois (not Neuchateli), Coast of Brittany (not Britanny), Parti nationaliste (not Nationalst), Cap-Haïtien (dash & diacritic—probably review Haïtien as well)
  • French culture names: Le Bœuf & Lebœuf (not Lebouef), Étienne (not Éttienne), d’Orléans (diacritic), French-Canadien (strange mixture between French-Canadian and canadien(ne))
  • French party names need a review of capitalisation
  • German: Südtirol, Siebenbürgen
  • Italian: Trentino-Alto Adige (mind the dash)
  • Spanish: rivers should use e.g. Río (but mind Anglicised names e.g. the Rio Grande in Mexico, and Portuguese names e.g. Rio de Janeiro), Platinean culture (either Platine or Rioplatense)
  • Portuguese: Curaçao
  • Swedish: Christerson (typo: Chrsiterson)

Country names

  • FSA: the Free American Empire could stand to extend to constitutional monarchy and fascist dictatorship
  • TKS_adj: Turkestani (Turkic)
@moretrim moretrim added enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2020
@moretrim moretrim self-assigned this Apr 22, 2020
@moretrim moretrim pinned this issue May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant