-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install NVM task fails on Ansible 7/core 2.14 #35
Comments
I appreciate the offer to submit a fix, however, I can't just remove something. Just because you are using X & Y version doesn't mean that other people aren't stuck with or opting to use older versions that still need support. This particular part of the code is a little gnarly as there are some potential security issues with piping. I've has some similar issues with newer Ansible upgrades #32 recently and have had to do some version checking. If you're willing to take the work, I'd welcome a PR |
Understood, that's why I opened this ticket to ask what a proper implementation looks like. As mentioned I'm not an Ansible expert so it's not clear to me why the |
Let me take a look and see what the options are. |
looking forward that fix too! I can't use packer build anymore |
Are there any updates on this issue? I'm currently running into this issue as well. |
My apologies, I was traveling for most of the past month and a half. I'm testing the fix, along with some other minor updates to the role. A fix should come this week or early next week. |
Made some updates and removed the thing that was bothering ya'll in the latest release. |
Hi @morgangraphics - thanks for this useful role!
Describe the bug
When I try to run this role with Ansible 7/core 2.14.1 installed, it fails at the "Install NVM task" with the following error:
I believe this is because the
warn
parameter was deprecated and removed in the latest Ansible version. If I comment out these lines in tasks.yml, the task runs correctly:I'd be happy to submit a PR removing these lines if, however I'm not enough of an Ansible expert to determine if that needs to be replaced with something, or if there are any other changes required to support Ansible core 2.14.
Expected behavior
The role should install NVM without throwing an error in the latest version of Ansible
To Reproduce
Shell [e.g. Bash, Dash, ksh, tcsh, zsh]
zsh on control node, bash on managed node
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: