Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better unicode support for python2 #214

Closed
ryan-collingham opened this issue Jul 5, 2019 · 1 comment
Closed

Better unicode support for python2 #214

ryan-collingham opened this issue Jul 5, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ryan-collingham
Copy link
Contributor

Many classes have a type schema that validates constructor params. Currently a lot of these validate strings against str, which in python 2 means that unicode strings are not allowed. Most of the time there is not a good reason to disallow unicode strings.

In python 2 the basestring type can be used to check if a string is either str or unicode. For python 3, basesting can be used via from past.builtins import basestring.

@ryan-collingham ryan-collingham added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Jul 5, 2019
@kn-ms
Copy link
Contributor

kn-ms commented Apr 14, 2024

No more python2 support

@kn-ms kn-ms closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants