Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to discard tabs on opening #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deadmeu
Copy link

@deadmeu deadmeu commented Jun 10, 2024

Adds a new option to open tabs by default in a discarded state. This is set to false by default which mimics the current behavior.

This dramatically reduces resource consumption when loading tabs and helps mitigate the risk of creating a large number of requests to a host resulting in being punished (e.g. by rate limited or denied access) for that event.

Closes #33.

@moritz-h
Copy link
Owner

Thanks, with a quick look this idea looks good.
I need to find some more time for detailed testing before I merge this. Especially, I'm interested if the discarded state may is somehow related to #23.

@deadmeu
Copy link
Author

deadmeu commented Jun 26, 2024

Thanks, with a quick look this idea looks good.
I need to find some more time for detailed testing before I merge this. Especially, I'm interested if the discarded state may is somehow related to #23.

#23 does not seem to be an issue for me with this change. With the tabs opened in a discarded state, the extension still correctly lists the urls in the URLs List window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tabs as discarded
2 participants