Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement queue #1

Closed
4 tasks done
moritz-weber opened this issue Apr 16, 2020 · 2 comments
Closed
4 tasks done

Implement queue #1

moritz-weber opened this issue Apr 16, 2020 · 2 comments
Labels
improvement Improving an existing feature

Comments

@moritz-weber
Copy link
Owner

moritz-weber commented Apr 16, 2020

  • implement actions to set/retrieve queue from background task
  • implement UI to display queue
  • implement logic to play next song in queue after current one finished

BUGS

  • NextIndicator and Previous/NextButton are not updating, when CurrentlyPlaying wasn't focused
@moritz-weber moritz-weber added the improvement Improving an existing feature label Apr 16, 2020
@moritz-weber moritz-weber modified the milestone: MVP Apr 16, 2020
@moritz-weber
Copy link
Owner Author

  • background task needs access to database -> MoorIsolate
  • bg task gets spawned by AudioManager
  • plugging MoorIsolate directly into AudioManager seems like a bad idea...

@moritz-weber
Copy link
Owner Author

moritz-weber commented Jul 5, 2020

  • Problem: MoorMusicDataSource is not initialized in background task, when first called --> ask on audio_service GitHub or create a custom event that the foreground task awaits

Idea:

  • do nothing in onStart (only completer.future)
  • after calling start, send a custom action to do the initializing and wait for that to finish

or

  • don't initialize MoorMusicDataSource on Start; instead check for null on usage and initialize when needed (maybe with a getter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improving an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant