Made it possible to subclass SwipyCell for custom tableview cells #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Class must be open (not just public) to subclass outside a module.
…. Class must be open (not just public) to subclass outside a module.
|
Do you need SwipyCell to be subclassable? Didn't think it was necessary, but if there is a demand I'm happy to merge! Thanks for the PR 😄 |
|
Well I'm new to iOS dev, so maybe I'm doing it wrong. But I need a custom table cell that has both the swipe properties from SwipyCell and custom layout with labels, images etc. Thus I've made my own MyTableViewCell as a subclass of SwipyCell. If thats the correct way to go about it, then it needs to be subclassable :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the SwipyCell class wasn't subclass-able with new access rules for Swift 3. See solution to: http://stackoverflow.com/questions/39072300/xcode-8-cannot-inherit-from-non-open-class
I needed a custom cell based on the SwipyCell class, so I just changed types access modifier from 'public' to 'open'. Use if you want :-)